-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added react-router v7 support #785
Conversation
@teukuamru is attempting to deploy a commit to the 47ng Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Maybe we could add a comment in the adapters/react-router
adapter mentioning it's for v6.
Also an update of the docs would be welcome, to point folks to the right adapter (using Callouts in the Remix section).
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
can't wait! |
@franky47 Is there anything blocking this? @teukuamru I see that the lint action failed - seems pretty easy to fix, the |
I need to find some free time to try out RRv7, I had an unpushed branch with Remix improvements that could also be factored in this. |
so, should I fix the lint or just wait for you to try out RRv7? |
I'll do it, I'm also going to add e2e tests for Remix, RRv6 & RRv7. |
# Conflicts: # pnpm-lock.yaml
commit: |
Merged but I want to add some more tests in a separate PR before shipping it to GA. In the mean time, y'all can use the preview deployment (feedback welcome!):
And import the adapter as such: // app/root.tsx
import { NuqsAdapter } from 'nuqs/adapters/react-router/v7'
// ...
export default function App() {
return (
<NuqsAdapter>
<Outlet />
</NuqsAdapter>
)
} |
404 not found |
@faradaytrs Try that URL: I'll check with the pkg.pr.new folks what went wrong with the PR-numbered release, thanks for the heads-up. |
i upgraded and it works fine, no problems detected |
🎉 This PR is included in version 2.3.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I'm using 2.3.0-beta.2 on a new RR7 app. I incorporated the adapter with export default function App() {
return (
<NuqsAdapter>
<Outlet />
</NuqsAdapter>
);
}``` |
@ZipBrandon thanks for the feedback and testing the beta! Could you open a dedicated issue with a repro link so I can take a look please? |
Added support for react-router v7.
Closes #782.