Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: composes on wrong class #471

Merged
merged 1 commit into from
Nov 5, 2019
Merged

fix: composes on wrong class #471

merged 1 commit into from
Nov 5, 2019

Conversation

jquense
Copy link
Contributor

@jquense jquense commented Nov 5, 2019

fixes #365

taion
taion approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@taion taion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there any downsides to always emitting an extra class? bundle size/whatever? or do they get optimized away... so just extra markup in css attribute in html. which doesn't matter

@jquense
Copy link
Contributor Author

jquense commented Nov 5, 2019

They should ultimately be optimized away, but I should really add a test that confirms that. Unclear if there other downsides...we will find out!

@jquense jquense merged commit afdb371 into master Nov 5, 2019
@jquense jquense deleted the composes-bug branch November 5, 2019 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taion taion taion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component property not working with composes
2 participants
@jquense @taion