fix: Fix plugin discovery in bundle to register them in napari viewer #1175

Czaki · 2024-08-09T10:33:12Z

Summary by CodeRabbit

New Features
- Enhanced the plugin registration process to dynamically discover and register plugins from specified directories.
- Improved extensibility and maintainability of the plugin system.

coderabbitai · 2024-08-09T10:33:19Z

Walkthrough

The recent update enhances the register_napari_plugins function, allowing it to dynamically discover and register plugins by scanning directories for napari.yaml files. By leveraging the pathlib module, the code improves extensibility and maintainability, making it easier to integrate new plugins without hardcoded paths. This change signifies a leap forward in the plugin registration process.

Changes

Files	Change Summary
`package/PartSeg/plugins/__init__.py`	Modified `register_napari_plugins` to enable dynamic discovery and registration of plugins from directories containing `napari.yaml` files.

Poem

In the plugin field where bunnies play,
New paths emerge, brightening the day.
With a hop and a skip, we register more,
Finding plugins galore, oh what a score!
🐇✨ Dynamic and swift, our joy is profound,
In the code's gentle dance, new friends abound!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sourcery-ai · 2024-08-09T10:33:20Z

🧙 Sourcery has finished reviewing your pull request!

Tips

Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
Continue your discussion with Sourcery by replying directly to review comments.
You can change your review settings at any time by accessing your dashboard:
- Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
- Change the review language;
You can always contact us if you have any questions or feedback.

sourcery-ai

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

coderabbitai

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 45d0f78 and 90310a2.

Files selected for processing (1)

package/PartSeg/plugins/init.py (2 hunks)

package/PartSeg/plugins/__init__.py

codecov · 2024-08-09T10:43:18Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.10%. Comparing base (45d0f78) to head (c6b6375).
Report is 41 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1175      +/-   ##
===========================================
+ Coverage    93.08%   93.10%   +0.01%     
===========================================
  Files          209      209              
  Lines        32885    32887       +2     
===========================================
+ Hits         30612    30619       +7     
+ Misses        2273     2268       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sonarcloud · 2024-08-09T11:59:21Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 90310a2 and c6b6375.

Files selected for processing (1)

package/PartSeg/plugins/init.py (2 hunks)

Files skipped from review as they are similar to previous changes (1)

package/PartSeg/plugins/init.py

fix plugin discovery in bundle

90310a2

Czaki added this to the 0.15.4 milestone Aug 9, 2024

sourcery-ai bot reviewed Aug 9, 2024

View reviewed changes

Czaki changed the title ~~Fix plugin discovery in bundle to register them in napari viewer~~ fix: Fix plugin discovery in bundle to register them in napari viewer Aug 9, 2024

coderabbitai bot reviewed Aug 9, 2024

View reviewed changes

package/PartSeg/plugins/__init__.py Outdated Show resolved Hide resolved

logging when problem with register plugin

c6b6375

coderabbitai bot reviewed Aug 9, 2024

View reviewed changes

Czaki merged commit b824e34 into develop Aug 9, 2024
55 checks passed

Czaki deleted the fix_register_plugin branch August 9, 2024 12:33

Czaki self-assigned this Aug 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Fix plugin discovery in bundle to register them in napari viewer #1175

fix: Fix plugin discovery in bundle to register them in napari viewer #1175

Czaki commented Aug 9, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 9, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

sourcery-ai bot commented Aug 9, 2024 •

edited

Loading

sourcery-ai bot left a comment

coderabbitai bot left a comment

codecov bot commented Aug 9, 2024 •

edited

Loading

sonarcloud bot commented Aug 9, 2024

coderabbitai bot left a comment

fix: Fix plugin discovery in bundle to register them in napari viewer #1175

fix: Fix plugin discovery in bundle to register them in napari viewer #1175

Conversation

Czaki commented Aug 9, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Aug 9, 2024 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

sourcery-ai bot commented Aug 9, 2024 • edited Loading

sourcery-ai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

codecov bot commented Aug 9, 2024 • edited Loading

Codecov Report

sonarcloud bot commented Aug 9, 2024

Quality Gate passed

coderabbitai bot left a comment

Choose a reason for hiding this comment

Czaki commented Aug 9, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 9, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

sourcery-ai bot commented Aug 9, 2024 •

edited

Loading

codecov bot commented Aug 9, 2024 •

edited

Loading