Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in documentation in "gqlgen/docs/content/reference/changesets.md" #1951

Open
Omkarz7 opened this issue Feb 7, 2022 · 2 comments · May be fixed by #1952
Open

Typo in documentation in "gqlgen/docs/content/reference/changesets.md" #1951

Omkarz7 opened this issue Feb 7, 2022 · 2 comments · May be fixed by #1952

Comments

@Omkarz7
Copy link

Omkarz7 commented Feb 7, 2022 •
edited
Loading

What happened?

Typo in gqlgen/docs/content/reference/changesets.md

type Mutation {
	updateUser(id: ID!, changes: UserChanges!): User
}

type UserChanges {
	name: String
	email: String
}

What did you expect?

type Mutation {
	updateUser(id: ID!, changes: UserChanges!): User
}

input UserChanges { // change type to input
	name: String
	email: String
}

Minimal graphql.schema and models to reproduce

  • Irrelevant

versions
@frederikhors
Copy link
Collaborator

frederikhors commented Feb 7, 2022 •
edited
Loading

@Omkarz7, can you create a PR so the credits for the modification are yours?

@Omkarz7
Copy link
Author

Omkarz7 commented Feb 7, 2022

Sure!
I have created a PR.
#1952

@Omkarz7 Omkarz7 linked a pull request Feb 9, 2022 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typo in docs Omkarz7/gqlgen
2 participants
@Omkarz7 @frederikhors