Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is GenerateCode called twice? #2526

Open
vikstrous2 opened this issue Jan 25, 2023 · 2 comments
Open

Why is GenerateCode called twice? #2526

vikstrous2 opened this issue Jan 25, 2023 · 2 comments

Comments

@vikstrous2
Copy link

Reading the code in api/generate.go, I see codegen.GenerateCode(data) called twice. Once before plugins run and once after. Why is this? It seems very wasteful. I see that there was an attempt to remove it in #1079 but that had to be reverted. I see that some things don't work correctly if it's removed. Is anything more known about why? What exactly needs to be done before vs after plugins run?

@vikstrous2
Copy link
Author

@vektah can you provide some info about why #1079 was reverted? Do you see any way to avoid calling GenerateCode twice?

@taako-502
Copy link
Contributor

@vikstrous2
#1100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants