BasicTypes "Byte" Binding for Scalars fails

[roneli]

What happened?

Since #2486 some common types don't get binded correctly

What did you expect?

Bytes to be binded to []bytes.

What happens that in this new function introduced in #2486

gqlgen/internal/code/compare.go

Line 167 in 9d22d98

func similarBasicKind(kind types.BasicKind) types.BasicKind {

Converts some basic kinds to "similar" types which makes sense in some cases as gqlgen converts Int into multiple types of int.

But in this case where we do the check in :

gqlgen/internal/code/compare.go

Line 43 in 9d22d98

if similarBasicKind(actualBasic.Kind()) != expected.Kind() {

It will fail as similar will convert byte -> int64 != byte.

Minimal graphql.schema and models to reproduce

scalar Bytes

type SomeBytesType {
   value: Bytes
}

And we add to the gqlgen the scalar + Unmarshal

versions

• go run github.com/99designs/gqlgen version? 0.17.24
• go version? 1.18