-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BasicTypes "Byte" Binding for Scalars fails #2524
Comments
roneli
added a commit
to roneli/gqlgen
that referenced
this issue
Jan 25, 2023
Found and issue from v0.17.24+ with binding bytes type Fixes 99designs#2524
2 tasks
mstephano
added a commit
to mstephano/gqlgen
that referenced
this issue
Jan 26, 2023
mstephano
added a commit
to mstephano/gqlgen
that referenced
this issue
Jan 26, 2023
mstephano
added a commit
to mstephano/gqlgen
that referenced
this issue
Jan 26, 2023
2 tasks
StevenACoffman
pushed a commit
that referenced
this issue
Jan 27, 2023
StevenACoffman
added a commit
that referenced
this issue
Mar 20, 2023
StevenACoffman
added a commit
that referenced
this issue
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
Since #2486 some common types don't get binded correctly
What did you expect?
Bytes to be binded to []bytes.
What happens that in this new function introduced in #2486
gqlgen/internal/code/compare.go
Line 167 in 9d22d98
Converts some basic kinds to "similar" types which makes sense in some cases as gqlgen converts Int into multiple types of int.
But in this case where we do the check in :
gqlgen/internal/code/compare.go
Line 43 in 9d22d98
It will fail as similar will convert byte -> int64 != byte.
Minimal graphql.schema and models to reproduce
And we add to the gqlgen the scalar + Unmarshal
versions
go run github.com/99designs/gqlgen version
? 0.17.24go version
? 1.18The text was updated successfully, but these errors were encountered: