Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AA2BBmap of a Equivariant Model #30

Open
zhanglw0521 opened this issue May 2, 2024 · 1 comment
Open

AA2BBmap of a Equivariant Model #30

zhanglw0521 opened this issue May 2, 2024 · 1 comment

Comments

@zhanglw0521
Copy link
Collaborator

This has been more or less discussed and I am not even sure whether this is a good way to put it, but would it be useful to make the AA2BB map of an EQM a passable variable? By default it should be set to nothing (and thus the SVD procedure is performed) but when needed we can pass in those sparse coupling coefficients (e.g., obtained and saved in previous calculations or so) so that the EQM doesn't need to run the SVD redundantly.

@cortner
Copy link
Member

cortner commented May 3, 2024

I would make this an internal method but not a public one. I.e. it is something that we can use for efficiency when developing, but I wouldn't make it user-facing and thus requiring documentation and backward compat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants