-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lux Extension #43
Comments
@CheukHinHoJerry -- I do wonder whether we are overcomplicating our life by not just making |
I think it depends what is our future direction to this package. It we simply want this to be a kernel-like package it is better not to add that. But personally I prefer adding that and we can then have flexibility on exporting functionalities like I was actually planning to start a new package by myself to do the |
So basically there are two ways to think about this:
The backend can then be swapped out as needed - e.g. @tjjarvinen will work on GPU kernels. I'm a bit on the fence. It feels like we can just work in P4ML for now but on the other hand there will be a bigger and bigger barrier to refactoring later. |
In terms of branding, I like the idea of an |
I think having front-end and back-end separate will be much better if we also want to support GPU kernels and have a long term development/support. Somehow like other deep learning packages calling |
Maybe we should have a meeting with @tjjarvinen and @zhanglw0521 to discuss this so that we can have a clearer direction to work on onwards? |
Yes, that sounds useful. |
@CheukHinHoJerry -- what was the outcome of our meeting on that point. Where do the Lux Layers go. Into P4ML or into EquivariantModels? |
I remember that we inclined to keep it in P4ML but I don't have a clear memory. Any idea? |
Right - I think Teemu said that there will simply be dispatch based on whether arrays are CPU types or GPU types. So now all we have left to decide is whether we make a Lux extension and have all Lux wrappers in there, or just make Lux a dependency and keep all Lux functionality locally with the different layers. I think we can choose one and change later, so the decision isn't crucial. Do you have a preferene? |
Yes - now I remember as you mentioned. Given that we are only using LuxCore, should be fine just to keep this as a direct dependency for now. But if we want to make use of Lux itself then I think we should make it an extension. |
I think this can be closed for now and revisited at some point if we feel like re-organizing codes again... |
Since J1.9 we have very convenient pkg extensions. We can implement additional Lux functionality or Zygote functionality or ... that gets loaded if and only if those packages are loaded by the user.
Just a thought for now. We can discuss.
The text was updated successfully, but these errors were encountered: