Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompilation #47

Closed
cortner opened this issue Jun 22, 2023 · 3 comments
Closed

Precompilation #47

cortner opened this issue Jun 22, 2023 · 3 comments

Comments

@cortner
Copy link
Member

cortner commented Jun 22, 2023

It seems P4ML doesn't precompile when used from ACE1x. See also ACEsuit/ACE1pack.jl#130

We need to fix this urgently.

CC @tjjarvinen @CheukHinHoJerry

@tjjarvinen
Copy link
Contributor

The short therm fix is adding __precompile__(false). This has no effect on the actual working of the package, except that it does not try to precompile and thus there will be no failure to precompile. Note that when precompile fails the package works like without precompile.

On fixing the issue itself. My quess is that ObjectPools might have something to do with this. Other than that Julia documentation has section on this topic.

When debugging this you can use Base.compilecache(Base.identify_package("modulename")) to trigger precompile and see does it work.

@CheukHinHoJerry
Copy link
Collaborator

I will try to see where is the problem and fix that.

@cortner cortner changed the title Procompilation Precompilation Jun 23, 2023
@cortner
Copy link
Member Author

cortner commented Jun 27, 2023

This was not an issue with P4ML but with ACE1x and RepLieGrps

@cortner cortner closed this as completed Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants