Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for variable number of walkers in WepyHDF5 #34

Open
salotz-sitx opened this issue Sep 10, 2021 · 1 comment
Open

Support for variable number of walkers in WepyHDF5 #34

salotz-sitx opened this issue Sep 10, 2021 · 1 comment

Comments

@salotz-sitx
Copy link
Collaborator

There is some basic considerations towards this, but a more thorough audit needs to be done to make sure that this is supported in a first class way.

Currently, if the number of walkers increases a new "trajectory" is added and in the trajectory group metadata a field is added noting which cycle it was created.

@salotz-sitx
Copy link
Collaborator Author

The first approach was to hack this into the "sparse fields" feature.

Options to make all fields sparse for variable number simulations was added (PR forthcoming).

This mostly works but is broken wrt mandatory "fields" i.e. weights. The proper solution then is support a dataset under each trajectory of _cycle_idxs and then _sparse_idxs for each field is relative to that. This allows for them both to coexist, which was a problem with the sparse fields for variable number of walkers hack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants