Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with GCC 8 #1018

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Fix build with GCC 8 #1018

merged 1 commit into from
Nov 16, 2022

Conversation

hahnjo
Copy link
Contributor

@hahnjo hahnjo commented Nov 16, 2022

It appears GCC had a bug, fixed in GCC 9.2, that incorrectly checks for a complete type in std::unique_ptr initialized with braces even if the constructors and the destructor are defined out-of-line, when the type is complete.

BEGINRELEASENOTES

  • Fix build with GCC 8

ENDRELEASENOTES

It appears GCC had a bug, fixed in GCC 9.2, that incorrectly checks
for a complete type in std::unique_ptr initialized with braces even
if the constructors and the destructor are defined out-of-line, when
the type is complete.
@andresailer
Copy link
Member

Thanks for this fix!

@andresailer andresailer merged commit 936a296 into AIDASoft:master Nov 16, 2022
@hahnjo hahnjo deleted the fix-gcc8 branch November 17, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants