Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LCIOConversions: fix attaching SimCaloHit collections to event #1019

Merged
merged 1 commit into from
Nov 17, 2022
Merged

LCIOConversions: fix attaching SimCaloHit collections to event #1019

merged 1 commit into from
Nov 17, 2022

Conversation

andresailer
Copy link
Member

BEGINRELEASENOTES

ENDRELEASENOTES

tmadlener
tmadlener approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran a quick test with a particle gun through the ILD detector and SimCalorimeterHit collections are present again.

@andresailer andresailer merged commit 2c77055 into AIDASoft:master Nov 17, 2022
@andresailer andresailer deleted the fixLcioCalos branch November 17, 2022 08:47
@Zehvogel Zehvogel mentioned this pull request May 23, 2023
Closed
@jmcarcell jmcarcell mentioned this pull request May 23, 2023
Merged
@jmcarcell jmcarcell mentioned this pull request Jun 27, 2023
Open
@jmcarcell jmcarcell mentioned this pull request Aug 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andresailer @tmadlener