Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Enable the GDML export / import tests again #1135

Closed
wants to merge 2 commits into from

Conversation

tmadlener
Copy link
Contributor

BEGINRELEASENOTES

  • Enable GDML export / import tests again

ENDRELEASENOTES

@andresailer @MarkusFrankATcernch the importing test is failing on my end due to:

[...]
21: Info in <TGeoManager::CloseGeometry>: 130882 nodes/ 808 volume UID's in Detector Geometry
21: Info in <TGeoManager::CloseGeometry>: ----------------modeler ready----------------
21: DD4hep           WARN  ++ STD conditions NOT defined by client. NTP defaults taken.
21: geoPluginRun: [   0.011 sec] Executed dd4hep plugin: 'DD4hep_ROOTGDMLParse' with args (6) :[ -input EcalBarrel.gdml -path /world/EcalBarrel -world world ]
21: ROOTGDMLParse    ERROR +++ Invalid DetElement path given: /world/EcalEndcap
21: RunPlugin        ERROR ++ Exception while executing plugin DD4hep_ROOTGDMLParse:
21: 		ROOTGDMLParse: +++ Invalid DetElement path given: /world/EcalEndcap
21: dd4hep: with plugin:DD4hep_ROOTGDMLParse
21: geoPluginRun: Got uncaught exception: RunPlugin: ++ Exception while executing plugin DD4hep_ROOTGDMLParse:
21: 		ROOTGDMLParse: +++ Invalid DetElement path given: /world/EcalEndcap
21: dd4hep: with plugin:DD4hep_ROOTGDMLParse
1/1 Test #21: t_CLICSiD_GDML_import_LONGTEST ...***Failed  Error regular expression found in output. Regex=[Exception]  1.27 sec

I haven't really started debugging that, maybe you have an idea on how to easily fix this?

@MarkusFrankATcernch
Copy link
Contributor

@tmadlener This looks very basic.

ROOTGDMLParse: +++ Invalid DetElement path given: /world/EcalEndcap

Are you sure there is no typo in the subdetector name ? This does not even start to invoke the GDML engine. It only tries to find the DetElement from where to start the export.

@MarkusFrankATcernch
Copy link
Contributor

MarkusFrankATcernch commented Jun 22, 2023

@tmadlener Very strange. When I execute the test locally on my box it runs without problems.....
OOPs sorry. I mixed it up with the export test....
The import test is indeed not working.

@github-actions
Copy link

Test Results

       6 files         6 suites   5h 4m 0s ⏱️
   348 tests    347 ✔️ 0 💤 1
1 034 runs  1 031 ✔️ 0 💤 3

For more details on these failures, see this check.

Results for commit 69b55de.

@MarkusFrankATcernch
Copy link
Contributor

@tmadlener Thomas, I will close this MR. I produced one with the full fix and unfortunately have no clu how to base on other MRs...

@tmadlener tmadlener deleted the re-enable-gdml-tests branch June 22, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants