Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix creation of tessellated shapes from CAD files. #1215

Merged
merged 6 commits into from
Jan 17, 2024
Merged

Fix creation of tessellated shapes from CAD files. #1215

merged 6 commits into from
Jan 17, 2024

Conversation

MarkusFrankATcernch
Copy link
Contributor

BEGINRELEASENOTES

@MarkusFrankATcernch
Copy link
Contributor Author

@andresailer FYI

  • I had to go back to TGeo's ComputeNormal implementation to get rid of the errors.
  • Also facets may only be added using the true vertices (double triplets). TGeoTessellated does then the correct thing and kills duplicated vertices from assimp.

@MarkusFrankATcernch MarkusFrankATcernch enabled auto-merge (rebase) January 17, 2024 14:57
@MarkusFrankATcernch MarkusFrankATcernch merged commit c0120cd into AIDASoft:master Jan 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarkusFrankATcernch