-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement CONST properties to optical sufaces. (Requires new release of ROOT) #1226
Merged
MarkusFrankATcernch
merged 15 commits into
AIDASoft:master
from
MarkusFrankATcernch:master
Feb 12, 2024
Merged
Implement CONST properties to optical sufaces. (Requires new release of ROOT) #1226
MarkusFrankATcernch
merged 15 commits into
AIDASoft:master
from
MarkusFrankATcernch:master
Feb 12, 2024
+6,986
−7,402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use of std namespace from some implementation files.
… use of std namespace from some implementation files.
… use of std namespace from some implementation files.
… use of std namespace from some implementation files.
Test Results 6 files 6 suites 2h 29m 12s ⏱️ Results for commit 85935a0. ♻️ This comment has been updated with latest results. |
MarkusFrankATcernch
force-pushed
the
master
branch
from
February 12, 2024 08:43
1574bd3
to
b1adaa9
Compare
This was referenced Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
Multiple commits. Most important one (on user request):
See issue: CONST properties for optical surfaces missing in DD4hep. #1223
Otherwise:
ENDRELEASENOTES