Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't clear sub-themes on reload #12

Open
regan-sarwas opened this issue Jul 18, 2019 · 0 comments
Open

Don't clear sub-themes on reload #12

regan-sarwas opened this issue Jul 18, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@regan-sarwas
Copy link
Member

regan-sarwas commented Jul 18, 2019

Currently when reloading a theme, all children are destroyed. This removes any custom paths to metadata, and any custom tags, summary, description data.

It makes sense to start with a clean slate, since reloading a theme could end up with all new sub-themes, or subtle changes to the equivalent sub-themes. However in many cases, when reloading a layerfile (or mxd) with multiple children, most sub-themes are the same. It seems reasonable to look at the new children and if any of the names are the same, then reuse (update the data path, and metadata path (so long as the new value is not null), but leave tags, description, summary as is (unless the user chooses to resync the metadata)) If there are existing children that did not match, then they get deleted. If there are new children that did not get a match, then they are added. This would be done recursively for all group layers.

@regan-sarwas regan-sarwas added the enhancement New feature or request label Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant