Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slashes in versioned docs #588

Open
QuantumDancer opened this issue Dec 14, 2023 · 0 comments
Open

Fix slashes in versioned docs #588

QuantumDancer opened this issue Dec 14, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation low priority

Comments

@QuantumDancer
Copy link
Contributor

QuantumDancer commented Dec 14, 2023

While the versioned docs (see #553 ) generally seem to work, I found to minor issues:

  1. The generated HTML code has unicode slashes (/) in link tags, while it has normal slashes for image tags (see the source code of https://alu-schumacher.github.io/AUDITOR//edge/):
<a href="https:&#x2F;&#x2F;alu-schumacher.github.io&#x2F;AUDITOR&#x2F;&#x2F;edge&#x2F;">
    <div class="logo">
        <img src="https://alu-schumacher.github.io/AUDITOR//edge/white_transparent_background.png" alt="logo">
         UDITOR
    </div>
</a>

Not sure if this is a problem or if all browser can handle addresses like https:&#x2F;&#x2F;alu-schumacher.github.io&#x2F;AUDITOR&#x2F;&#x2F;edge&#x2F;

Also not sure, why this happens for link tags but not for image ones. Maybe some sort of URL encoding going in in the zola build? This also occurs for the old version docs that have been generated on a local machine (e.g. view-source:https://alu-schumacher.github.io/AUDITOR/v0.3.1/)

  1. The GITHUB_PAGES_URL already contains a trailing slash. Right now be build the base URL with ${{ env.GITHUB_PAGES_URL }}/${{ env.RELEASE_VERSION }}, which should be changed to ${{ env.GITHUB_PAGES_URL }}${{ env.RELEASE_VERSION }}
@QuantumDancer QuantumDancer added documentation Improvements or additions to documentation low priority labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation low priority
Projects
None yet
Development

No branches or pull requests

1 participant