Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rotation convention mismatch with scipy.spatial.transform.Rotation #21

Open
babiking opened this issue Oct 27, 2021 · 0 comments
Open

Comments

@babiking
Copy link

babiking commented Oct 27, 2021

lie-learn output a Y-X-Y Euler 3D rotation within pinchon_hoggan_dense module, but not Z-Y-Z as it should be.

p.s.
for wigner-D-matrix, when rotation degree L = 1, D(1, g) is a rotation matrix, i.e. R(g). Through a simple unit-test, I found the following 2 implementations are equivalent (i.e. D == R):

alpha, beta, gamma = np.random.rand(3) * 2.0 * np.pi

No.1
from lie_learn.representations.SO3.wigner_d import wigner_D_matrix
D = wigner_D_matrix(1, alpha, beta, gamma)

No.2
from scipy.spatial.transform import Rotation
R = Rotation.from_euler('YXY', [alpha, beta, gamma], degrees=False).as_matrix()

so, lie-learn mismatches with scipy on rotation convention?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant