Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing-slash policy inconsistency #22

Open
garethsb opened this issue Apr 17, 2019 · 5 comments
Open

Trailing-slash policy inconsistency #22

garethsb opened this issue Apr 17, 2019 · 5 comments
Labels
dependency issue This issue depends on an issue in an 'upstream' specification

Comments

@garethsb
Copy link
Contributor

https://github.com/AMWA-TV/nmos-event-tally/blob/v1.0/docs/6.0.%20Event%20and%20tally%20rest%20api.md#2-nmos-resource

For consistency the href url offered will always end with a trailing slash.

is in direct contradiction with

https://github.com/AMWA-TV/nmos-discovery-registration/blob/v1.2.1/docs/2.0.%20APIs.md#urls-approach-to-trailing-slashes

For consistency and in order to adhere to how these APIs are specified in RAML, the 'primary' path for every resource has the trailing slash omitted.

(See also AMWA-TV/is-04#87, and AMWA-TV/is-05#65.)

@garethsb
Copy link
Contributor Author

@cristian-recoseanu
Copy link
Contributor

Hi @garethsb-sony

The href in the controls array is not a primary path is it?
It's consistent with how IS-05 v1.3 href is expressed in the controls array from here:

https://amwa-tv.github.io/nmos-device-connection-management/tags/v1.0.1/docs/3.1.Interoperability-_NMOS_IS-04.html

Unless that is wrong as well.

@garethsb
Copy link
Contributor Author

garethsb commented May 2, 2019

The href in the controls array is not a primary path is it?

Personally, I believe it is referring to a primary path.

(Link didn't work for me, due to GitHub's rendering of underscores. This should work: https://amwa-tv.github.io/nmos-device-connection-management/tags/v1.0.1/docs/3.1._Interoperability_-_NMOS_IS-04.html.)

Unless that is wrong as well.

As noted in AMWA-TV/is-04#87, "in many cases in the documentation, examples include a trailing slash when they should not. These ought to be addressed, and the expectations placed upon clients in processing them clarified."

The important part of this is mostly to make clear that clients cannot blindly append sub-paths to a URL which may or may not end in a trailing slash.

@mjeras
Copy link
Contributor

mjeras commented May 7, 2019

@garethsb-sony , do you think we should address this in the IS-07 project now, or should we start a NMOS-wide discussion on this and then address it across all projects (maybe in NMOS Core)?

@garethsb
Copy link
Contributor Author

Another example in IS-07 that contradicts the usual guidance: the documentation for ext_is_07_rest_api_url says:

"For consistency the ext_is_07_rest_api_url url offered will always end with a trailing slash."

@garethsb garethsb added the dependency issue This issue depends on an issue in an 'upstream' specification label May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency issue This issue depends on an issue in an 'upstream' specification
Projects
None yet
Development

No branches or pull requests

3 participants