Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLYCbCr, XYZ and KEY colorimetry #35

Open
garethsb opened this issue Nov 30, 2021 · 1 comment
Open

CLYCbCr, XYZ and KEY colorimetry #35

garethsb opened this issue Nov 30, 2021 · 1 comment

Comments

@garethsb
Copy link
Contributor

garethsb commented Nov 30, 2021

ST 2110-20 and RFC 9134 (JPEG XS) define colorimetry values for CLYCbCr (constant luminance YCbCr), and XYZ colorspaces, and key.

IS-04 v1.3 raw video Flow components cannot represent these colorspaces, because the enum for components.name doesn't include the necessary entries and there isn't an escape via e.g. a string pattern.

PR #33 added support for components for coded video Flows, e.g. JPEG XS, using the same definition.

Should we add enum entries to the schema in the Parameter Registers even though this wouldn't solve the problem for video/raw Flows?

E.g.

              "Yc",
              "Cbc",
              "Crc",
              "X",
              "Z",
              "Key",

Or should we roll that back and add a color_sampling attribute (with values like the same-named parameter constraint in the Capabilities register) instead?


FWIW, there are just a few other "closed enums" in IS-04 and IS-05 that we might prefer were open to extension without having to bump the spec version...

In IS-04

In IS-05

  • fec_type has fixed options of XOR and Reed-Solomon (sufficient for all time?!)
  • more importantly /transporttype has a fixed list of options (and a larger change would be needed to make the schemas for new transport types "pluggable")
@garethsb garethsb changed the title CLYCbCr, ICtCp, XYZ and KEY colorimetry CLYCbCr, XYZ and KEY colorimetry Nov 30, 2021
@andrewbonney
Copy link
Contributor

Given that the JXS flow register adds to other enums already, I would suggest there is little harm in doing the same for the component name. This perpetuates the intended flexibility of the structure and doesn't result in duplication.

The closed enum issue ought to be dealt with in IS-04/05. This is clearly going to become a bigger issue in the future and given that we now have an extension mechanism in the parameter registers which we didn't have when the enums were originally created I'd hope this would be simple to specify. The question of whether this requires a version bump will have to go to the group as the bump mechanism is clearly there to help systems which might not have accounted for this and don't handle it gracefully, but as we know a version bump has its own downsides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants