Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format gui slot don't work when wait is used in the second create/edit gui section #131

Closed
AKtomik opened this issue Aug 10, 2022 · 2 comments
Labels
bug Something isn't working completed Bug fix / enhancement will be available in the next release

Comments

@AKtomik
Copy link

AKtomik commented Aug 10, 2022

Description

the format gui slot effect don't work, when wait is used in the second create/edit gui section who following (in the same section).

Steps to Reproduce

  1. have a code section (here the trigger: section)
  2. Write a first create/edit gui section.
    No matter lines in this section. - This section work perfectly.
  3. Write a second create/edit gui section.
  4. Put inside a wait effect.
  5. Any format gui effect who are after the wait (in the second create/edit gui section) do not work.

File1.sk work :

command /test:
	trigger:
		create gui with id "1" with virtual chest inventory with 1 rows named "&f1":
			open gui with id "1" to player
			format gui slot 1 with dirt
			broadcast "you must see dirt"#yes
			wait 1 second
			format gui slot 2 with diamond
			broadcast "you must see diamond"#yes
			
			broadcast "test is end"
			delete gui with id "1"

File2.sk dont work :

command /test:
	trigger:
		create gui with id "3" with virtual chest inventory with 1 rows named "&f3":#if you remove this line or you delete ':', the bug isn't here
		create gui with id "2" with virtual chest inventory with 1 rows named "&f2":
			open gui with id "2" to player
			format gui slot 1 with dirt#work
			broadcast "you must see dirt"#yes
			wait 1 second
			format gui slot 2 with diamond#**dont work**
			broadcast "you must see diamond"#no
			
			broadcast "test is end"
			delete gui with id "3"
			delete gui with id "2"

we can see the diamond and th dirt in the gui "1", but in the second section, we can't see the diamond, just the dirt.
note : if we replace gui create sections with gui edit section, that change nothing

Expected Behavior

patch this bug : make the create section "2" works like create section "1" .

Errors / Screenshots

Gifs show the execution of File1.sk and File2.sk
File1
File2

Server Information

  • Server version/platform: This server is running Paper version git-Paper-121 (MC: 1.19.2) (Implementing API version 1.19.2-R0.1-SNAPSHOT) (Git: 954b3fb)
  • skript-gui version: skript-gui version 1.3-beta2
  • Skript version: Skript version 2.6.3

Additional Context

sorry if my English is bad, im french.
Thank you for your work, your plugin is really useful !

@AKtomik AKtomik added the bug Something isn't working label Aug 10, 2022
@APickledWalrus
Copy link
Owner

This is likely an issue with the "inception" checks that are done during GUI creation. I'll take a look at possible fixes. Thanks for the report!

@APickledWalrus APickledWalrus added the completed Bug fix / enhancement will be available in the next release label Aug 11, 2022
@APickledWalrus
Copy link
Owner

Should be fixed with that commit. You can test using https://github.com/APickledWalrus/skript-gui/suites/7774834055/artifacts/327125590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working completed Bug fix / enhancement will be available in the next release
Projects
None yet
Development

No branches or pull requests

2 participants