Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nRF5xn::init don't verify if errors have occurred during btle_init #59

Closed
pan- opened this issue Nov 3, 2015 · 4 comments
Closed

nRF5xn::init don't verify if errors have occurred during btle_init #59

pan- opened this issue Nov 3, 2015 · 4 comments

Comments

@pan-
Copy link
Member

pan- commented Nov 3, 2015

See this at: https://github.com/ARMmbed/ble-nrf51822/blob/master/source/nRF5xn.cpp#L94 .
The init process should check and report if something has gone wrong

@rainierwolfcastle
Copy link

ARM Internal Ref: IOTSFW-1168

@andresag01
Copy link

@pan- @rgrover : It is easy to simply return BLE_ERROR_UNSPECIFIED when a call to ble_init() fails. However, this might not be the ideal solution. The main problem is that we do not have sufficient error codes to be more specific about the cause of the problem. Is it acceptable to return BLE_ERROR_UNSPECIFIED when there is a failed call to ble_init()? Should we are more error codes to ble/blecommon.h in BLE API?

@pan-
Copy link
Member Author

pan- commented Dec 18, 2015

What would you want to return ?

@andresag01
Copy link

Submitted a pull request ARMmbed/ble#155 to add another error code to the API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants