Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch and filter_jobs methods don't match jobs methods #59

Open
jhkennedy opened this issue Dec 18, 2020 · 2 comments
Open

Batch and filter_jobs methods don't match jobs methods #59

jhkennedy opened this issue Dec 18, 2020 · 2 comments

Comments

@jhkennedy
Copy link
Contributor

Job exposes:

  • Job.succeeded()
  • Job.failed()
  • Job.complete()
  • Job.running()

While Batch exposes:

  • Batch.succeeded()
  • Batch.complete()

Additionally, Batch.filter_jobs filters on succeeded, running, and failed.

It's a little weird when writing examples and documentation to not have Batch.running and Batch.failed, but filter jobs on them.

@jhkennedy
Copy link
Contributor Author

jhkennedy commented Feb 5, 2021

Additionally, it'd be nice to add some more filters:

  • Job Type

And maybe by_fn which would use a true false return of a function to filter jobs out

  • this could be combined with asf_search.granule_metadata to filter based on all kinds of info

@Jlrine2 Jlrine2 closed this as completed Mar 23, 2021
@Jlrine2 Jlrine2 reopened this Mar 23, 2021
@Jlrine2
Copy link
Contributor

Jlrine2 commented Mar 23, 2021

whoops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants