Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move/move conflict detection is non-deterministic #101

Closed
slarse opened this issue Apr 14, 2020 · 0 comments
Closed

Move/move conflict detection is non-deterministic #101

slarse opened this issue Apr 14, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@slarse
Copy link
Collaborator

slarse commented Apr 14, 2020

Because in a move/move conflict, each PCS containing the moved node will conflict with two other PCSes (base and left, base and right or left and right). The problem is that the PCSes from the left and right revisions that conflict with each other will conflict with two different PCSes from the base revision. If these base revision PCSes are removed during merging, then the PCSes from left and right will never be found to conflict.

I will put a more detailed explanation in the thesis.

The quick fix for this is to modify getOtherX to return all conflicting PCSes of that type.

@slarse slarse added the bug Something isn't working label Apr 14, 2020
@slarse slarse closed this as completed in c95b20e Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant