Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: DDIM with AND keyword : OK in negative but KO in positive ? #5483

Closed
1 task done
Ehplodor opened this issue Dec 6, 2022 · 2 comments
Closed
1 task done

[Bug]: DDIM with AND keyword : OK in negative but KO in positive ? #5483

Ehplodor opened this issue Dec 6, 2022 · 2 comments
Labels
bug-report Report of a bug, yet to be confirmed

Comments

@Ehplodor
Copy link

Ehplodor commented Dec 6, 2022

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What happened?

When generating images using DDIM sample, I tried AND operator in negative prompt. Getting somehow good results. No error.

But when I tried to add some AND keyword to the positive prompt, it crashed.

Reason is : AND keyword don't work with DDIM / PLMS sampler, as written in #1695 and in #3747.

However what I just don't understand is : Why didn't it crash when only ANDs in negative prompt ? I have'nt gottend deep enough into the code currently, to answer this question myself.

Best regards.

Steps to reproduce the problem

  1. Go to txt2img and select DDIM
  2. write some prompt, using AND keyword in negative, generate and see that it doesn't crash
  3. write some prompt, using AND keyword in positive, generate and see that it crash

What should have happened?

After reading both linked thread, I thought that it should have crashed since the first prompt using negative ANDs

Commit where the problem happens

44c46f0

What platforms do you use to access UI ?

No response

What browsers do you use to access the UI ?

No response

Command Line Arguments

--xformes --device-id 0

Additional information, context and logs

No response

@Ehplodor Ehplodor added the bug-report Report of a bug, yet to be confirmed label Dec 6, 2022
@ClashSAN
Copy link
Collaborator

ClashSAN commented Dec 7, 2022

@Ehplodor, I don't know if the AND has any effect for the negative prompt, it doesn't seem like the option was added at the beginnings, right? and I think that's what AND NOT would have been, dividing the negative prompt from 50% to two 25% prompts, three 16.7% prompts..

@Ehplodor
Copy link
Author

Ehplodor commented Dec 7, 2022

@Ehplodor, I don't know if the AND has any effect for the negative prompt, it doesn't seem like the option was added at the beginnings, right? and I think that's what AND NOT would have been, dividing the negative prompt from 50% to two 25% prompts, three 16.7% prompts..

Well, I did not dig into the code at present so not very confident but yes, it seems like AND is not implemented in the negative prompt. Else that would have crashed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-report Report of a bug, yet to be confirmed
Projects
None yet
Development

No branches or pull requests

2 participants