Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: "Batch from directory" limited to 238 pictures #7890

Closed
1 task done
0nl1n1n opened this issue Feb 17, 2023 · 6 comments · Fixed by #12479
Closed
1 task done

[Bug]: "Batch from directory" limited to 238 pictures #7890

0nl1n1n opened this issue Feb 17, 2023 · 6 comments · Fixed by #12479
Labels
bug Report of a confirmed bug

Comments

@0nl1n1n
Copy link

0nl1n1n commented Feb 17, 2023

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What happened?

While running a batch of thousands pictures in the "Extras -> Batch from directory" - I noticed that only 238 pictures were upscaled before coming to a full stop.
No error message.

Steps to reproduce the problem

  1. Go to the "Extras Tab"
  2. Select "Batch from directory"
  3. Select a directory with more than 238 pictures
  4. Run the upscale on Lanczos

What should have happened?

The script should continue as long as there are pictures in the folder.

Commit where the problem happens

45a8b75

What platforms do you use to access the UI ?

MacOS

What browsers do you use to access the UI ?

Brave

Command Line Arguments

No

List of extensions

ABG_extension https://github.com/KutsuyaYuki/ABG_extension.git unknown
sd-dynamic-prompts https://github.com/adieyal/sd-dynamic-prompts unknown
stable-diffusion-webui-wildcards https://github.com/AUTOMATIC1111/stable-diffusion-webui-wildcards unknown
LDSR built-in
ScuNET built-in
SwinIR built-in
prompt-bracket-checker built-in
roll-artist built-in

Console logs

No long in the console for that feature.

Additional information

No response

@0nl1n1n 0nl1n1n added the bug-report Report of a bug, yet to be confirmed label Feb 17, 2023
@AlUlkesh
Copy link
Contributor

I just tried this with 500 images in a directory. Worked without issues.

Are you always trying this on the same directory? Perhaps there's an issue with your 238th image?

@ClashSAN ClashSAN added the cannot-reproduce I can't reproduce this, so I can't fix it. Add steps for reproduction and remove this tag. label Feb 18, 2023
@vladmandic
Copy link
Collaborator

same user posted the question few days ago in discussions, had the same answer. in either case - if there is an issue, needs more info.

@0nl1n1n
Copy link
Author

0nl1n1n commented Feb 19, 2023

I just tried this with 500 images in a directory. Worked without issues.

Are you always trying this on the same directory? Perhaps there's an issue with your 238th image?

No, I actually have to do batches of 238 pictures each time. Not sure how I can further pin down where the problem comes from since there are no logs in the console.

@qodjf
Copy link

qodjf commented Jun 19, 2023

It is caused by too many open files. You can solve it by run ulimit -n 50000.

There should be a print in https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/master/modules/postprocessing.py#L37.

Refer to https://stackoverflow.com/questions/18280612/ioerror-errno-24-too-many-open-files.

@TheOnlyHolyMoly
Copy link

@vladmandic FYI

@catboxanon catboxanon added bug Report of a confirmed bug and removed cannot-reproduce I can't reproduce this, so I can't fix it. Add steps for reproduction and remove this tag. bug-report Report of a bug, yet to be confirmed labels Aug 11, 2023
@catboxanon
Copy link
Collaborator

Fixed in #12479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of a confirmed bug
Projects
None yet
7 participants