-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add virtual display python bindings #1464
Add virtual display python bindings #1464
Conversation
Signed-off-by: Michael Dolan <michdolan@gmail.com>
@meimchu are you still interested in writing tests for these new Python bindings? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But I think there should be at least one Python test. Even if that's platform specific you can get some hints from Config_tests.cpp OCIO_ADD_TEST(Config, virtual_display)
to create something platform agnostic (and postpone the platform specific parts for now).
That's a candidate for 2.0.2 |
Signed-off-by: Michael Dolan <michdolan@gmail.com>
Added an implementation of the platform agnostic portion of |
Thanks @michdolan for pinging me about this. Let me take a look at it for creating python unit tests! |
@meimchu I reimplemented a basic test from the C++ unit tests so this can be merged, but as this is a complex feature there is more work to be done in a future PR, specifically testing the platform specific virtual display/system monitor interaction. Examples of that also live in the C++ tests. Thanks for your help! |
As mentioned on Slack, should we port this to the RB 2.0 branch? This is currently not available on 2.0.3 but is on 2.1.0 as @doug-walker found. |
The idea around a potential 2.0.3 version is to only bring critical fixes (e.g. color processing errors like in 2.0.2) and suggest users to switch to the latest 2.1 version as soon as possible. At a technical point of view, updating from 2.0.x to 2.0.4 or 2.1.2 should be the same among of work. The point is to put extra attention not increasing too much the number of supported versions. So, I suggest you to bring the topic to the next TSC meeting to agree on a version support policy. |
Thanks @hodoulp, I'll add it to the agenda for the next meeting. |
* Add virtual display python bindings Signed-off-by: Michael Dolan <michdolan@gmail.com> * Add virtual display test, missing methods Signed-off-by: Michael Dolan <michdolan@gmail.com>
#1611) * Add virtual display python bindings (#1464) * Add virtual display python bindings Signed-off-by: Michael Dolan <michdolan@gmail.com> * Add virtual display test, missing methods Signed-off-by: Michael Dolan <michdolan@gmail.com> * Fix the Config Python binding Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com> Co-authored-by: Michael Dolan <michdolan@gmail.com>
Adds missing Python bindings for OCIO Config virtual display interface.
Fixes #1317