Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not assume minizip-ng uses zlib for compression #1796

Conversation

MarcusCalhoun-Lopez
Copy link

The file mz_strm_zlib.h does not exist if minizip-ng enables compression via means other than zlib.
Since none of the functions provided by mz_strm_zlib.h are used (mz_stream_zlib_*), it can be safely removed.

The file mz_strm_zlib.h does not exist if minizip-ng enables
compression via means other than zlib.
Since none of the functions provided by mz_strm_zlib.h
are used (mz_stream_zlib_*), it can be safely removed.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 10, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: MarcusCalhoun-Lopez (39786a3)

@cedrik-fuoco-adsk
Copy link
Contributor

Thanks for the contribution @MarcusCalhoun-Lopez.

Could you resolve the DCO and EasyCLA issues? The PR needs that to be accepted.

Thanks!

@MarcusCalhoun-Lopez
Copy link
Author

MarcusCalhoun-Lopez commented May 22, 2023

Could you resolve the DCO and EasyCLA issues? The PR needs that to be accepted.

Thank you for the reminder.
I believe I am covered now.

@cedrik-fuoco-adsk
Copy link
Contributor

Hi @MarcusCalhoun-Lopez,

Thank you for fixing the EasyCLA. It seems like the DCO is still failing because one of the commit is not signed.
Could you fix that as well?

Thanks!

@doug-walker
Copy link
Collaborator

Thanks for the suggestion @MarcusCalhoun-Lopez , Cedrik and I agree this is a good fix and we will incorporate it into a future PR.

@remia
Copy link
Collaborator

remia commented Nov 15, 2023

Thanks for the PR @MarcusCalhoun-Lopez, as there was still a DCO issue we couldn't merge this but the fix is included in #1902 which was just merged. I'm going to close this one then.

@remia remia closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants