-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.13 wheels #2052
Python 3.13 wheels #2052
Conversation
Signed-off-by: Rémi Achard <remiachard@gmail.com>
Signed-off-by: Rémi Achard <remiachard@gmail.com>
Signed-off-by: Rémi Achard <remiachard@gmail.com>
@@ -13,6 +13,7 @@ classifiers = | |||
Programming Language :: Python :: 3.10 | |||
Programming Language :: Python :: 3.11 | |||
Programming Language :: Python :: 3.12 | |||
Programming Language :: Python :: 3.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we pop the Programming Language :: Python :: 3.7
classifier above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point and I was also wondering about it, here we simply remove wheels for 3.7 but users could still build manually for Python 3.7 and use it. We are still testing Python 3.7 with the VFX 2020 platform docker images, though it's about to be removed in the VFX 2024 PR. So all that to say that I have no objections to remove :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the Scientific Python SPEC0, support for Python 3.10 is about to be dropped: https://scientific-python.org/specs/spec-0000/, CY2023 is Python 3.10, and Python 3.7 is CY2021.
I think that as a whole, there should be an ASWF consensus on which minimum Python version to support, especially when some of the core packages we are relying on, e.g., Numpy have seen their support dropped. In Colour, we split the apple in two and support the previous VFX Reference Platform year as minimum. Let's discuss at TSC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot that VFX 2021 is still using Python 3.7, for now let's keep it in there as there was no strong feeling against at yesterday TSC. We should definitively make sure we have a defined plan for older platform support so worth discussing at the next TSC when you are there :)
LGTM besides the classifier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this Remi!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Really strange, that the OCIO_PYTHON_LOAD_DLLS_FROM_PATH thing is causing problems. That's pretty baffling.
Do we want to support free-threaded mode too for Python 3.13?
For the segfault, let's continue the discussion in #2040! I don't think we have the resources to add support for GIL-free Python in the coming release and not exactly sure yet what work will be required to be honest. From a quick look, I assume we have to upgrade to pybind 2.13 and start using |
* Python 3.13 wheels Signed-off-by: Rémi Achard <remiachard@gmail.com> * Build mac ARM wheels on Apple Silicon runners to enable testing Signed-off-by: Rémi Achard <remiachard@gmail.com> * Fix upload_pypi job dependencies Signed-off-by: Rémi Achard <remiachard@gmail.com> --------- Signed-off-by: Rémi Achard <remiachard@gmail.com> Signed-off-by: Chris Nash <chris.nash@disguise.one>
Here is a list of changes included:
Tagging @KelSolaar