Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer environment variables are not added to XML spec #547

Closed
larsbijl opened this issue Nov 24, 2019 · 9 comments · Fixed by #876
Closed

Layer environment variables are not added to XML spec #547

larsbijl opened this issue Nov 24, 2019 · 9 comments · Fixed by #876
Assignees
Labels
bug Something isn't working good first issue Good for newcomers triaged Issue has been screened and prioritized by a project lead

Comments

@larsbijl
Copy link
Contributor

Describe the bug
The XML spec allows for env variables to be set on a layer. They are not propagated to cuebot.

To Reproduce
Create a simple submission with an env variable set to the layer.

Check the layer_env. Nothing.

@larsbijl larsbijl added the bug Something isn't working label Nov 24, 2019
@larsbijl larsbijl self-assigned this Jan 23, 2020
@bcipriano bcipriano added the triaged Issue has been screened and prioritized by a project lead label Jan 24, 2020
@bcipriano bcipriano added the good first issue Good for newcomers label Feb 8, 2020
@pcube99
Copy link

pcube99 commented Feb 21, 2020

@larsbijl @bcipriano I want to contribute to this issue !!

@larsbijl
Copy link
Contributor Author

hey @pcube99,

Feel free to contribute :)

@pcube99
Copy link

pcube99 commented Feb 21, 2020

can you elaborate what I am supposed to do ?

@larsbijl
Copy link
Contributor Author

Hey @pcube99,

when you create a submission using pyoutline you can add environment variables to an outline using the set_env. this is written into the XML specification here and consumed here

When you look at the Database the table layer_env remains empty. it should hold the environment variables given to it.

The problem could be in the section above in pyoutline or in cuebot when it creates the job.

@bcipriano
Copy link
Collaborator

@pcube99 Thank you for the offer, it's much appreciated :)

Lars's comment should get you started but let us know if you have any questions. https://www.opencue.io/contributing/ has some good resources (I'm working on a Mac and Linux version of the Getting Started guide which should be ready soon).

@bcipriano
Copy link
Collaborator

@pcube99 Any update on this issue? Please let me know by tomorrow if you plan to work on this still so I can free it up for someone else.

@pcube99
Copy link

pcube99 commented Mar 26, 2020

you can assign it to someone else, i am not able to make any progress.

@apoorvkhare07
Copy link
Contributor

@bcipriano can I take up this issue?

@bcipriano
Copy link
Collaborator

Yes, go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers triaged Issue has been screened and prioritized by a project lead
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants