Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rez executables aren't removed in windows install #1258

Closed
nerdvegas opened this issue Mar 24, 2022 · 1 comment · Fixed by #1259
Closed

rez executables aren't removed in windows install #1258

nerdvegas opened this issue Mar 24, 2022 · 1 comment · Fixed by #1259
Assignees
Labels

Comments

@nerdvegas
Copy link
Contributor

As part of the install process, rez cli tools are copied into a /rez subdir within the venv bin path - this is so that other unrelated exes (such as python) aren't accidentally run from rez's venv. See https://github.com/nerdvegas/rez/blob/master/install.py#L86-L90.

The specs.keys() returns a list like ['rez', 'rezolve', '_rez-complete', '_rez_fwd', 'rez-bind', 'rez-build', ...], but on windows the files all have the ".exe" extension. Meaning the line if os.path.isfile(filepath): always returns False, and those files never get deleted.

To Reproduce

  1. perform an install on windows

Expected behavior
rez cli tools in root bin dir are deleted

Actual behavior
rez cli tools in root bin dir are not deleted

Related Issues/PRs

@instinct-vfx
Copy link
Contributor

Good catch hughetop. That had never occured to me as i never really loooked into the non-rez folder. Will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants