Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rez-pip does not include platform/arch in generated variants for pure python packages with console_scripts #907

Closed
bpabel opened this issue Jul 17, 2020 · 2 comments
Labels
bug rez-pip ingesting py pkgs into rez (pip, wheels, etc)

Comments

@bpabel
Copy link
Contributor

bpabel commented Jul 17, 2020

When building a python package that contains console_script entry points, python build systems will generate an platform/arch-specific binary executable.

Because this executable is platform/arch-specific, the platform/arch should be included in the generated variant. This will allow rez-pip to be run from multiple platform/arch's, each building different variants with different console_script executables.

@nerdvegas
Copy link
Contributor

Do you know if this is also the case for linux? I'd have thought not as shebanged scripts are created in that case.

In any case, no work has been put into detecting platform-dependent packages as yet, but we can start, even if that's just getting set for packages with console entry points on Windows.

@JeanChristopheMorinPerso JeanChristopheMorinPerso added bug rez-pip ingesting py pkgs into rez (pip, wheels, etc) labels Mar 11, 2023
@JeanChristopheMorinPerso
Copy link
Member

Fixed by #1287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug rez-pip ingesting py pkgs into rez (pip, wheels, etc)
Projects
None yet
Development

No branches or pull requests

3 participants