Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New spawned shell's PATH is random ordered on Windows #925

Closed
davidlatwe opened this issue Aug 9, 2020 · 0 comments
Closed

New spawned shell's PATH is random ordered on Windows #925

davidlatwe opened this issue Aug 9, 2020 · 0 comments

Comments

@davidlatwe
Copy link
Contributor

Problem

New spawned cmd and powershell has random ordered PATH injected, the order of paths in PATH should be respected or the behavior in the new shell might be unexpected.

Cause

These two lines here use set to cleanup duplicated path, the motivation was good but the ordering is undesired.
https://github.com/nerdvegas/rez/blob/def201aca819862470b879d5beb75fcf3d46f87f/src/rezplugins/shell/cmd.py#L135
https://github.com/nerdvegas/rez/blob/def201aca819862470b879d5beb75fcf3d46f87f/src/rezplugins/shell/_utils/powershell_base.py#L123

Since my machine at home was pretty nasty plus WindowsApps' fake python.exe (see tweet), this random ordered PATH was pretty obvious to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant