You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When testing the migration of ARC ActivitySim Version 1.0, I encountered a number of dataframe variable name changes as well as YAML syntax differences.
While not terribly complex changes, the V1.0 commits were clearly aware that changes needed to be made to the ARC implementation, because changes were made in the ARC example. In the future, a better way to handle this type of change would be to also submit a PR with the same changes to the ARC GitHub implementation.
These commits also do not adhere to the commit Review Criteria:
Does it appropriately interact with the data pipeline (i.e. it doesn’t create new ways of managing data)?
Does it include sufficient test coverage and test data for existing and proposed features?
Example (Work Location):
Example (At-Work Subtour)
The text was updated successfully, but these errors were encountered:
When testing the migration of ARC ActivitySim Version 1.0, I encountered a number of dataframe variable name changes as well as YAML syntax differences.
While not terribly complex changes, the V1.0 commits were clearly aware that changes needed to be made to the ARC implementation, because changes were made in the ARC example. In the future, a better way to handle this type of change would be to also submit a PR with the same changes to the ARC GitHub implementation.
These commits also do not adhere to the commit Review Criteria:
Example (Work Location):
Example (At-Work Subtour)
The text was updated successfully, but these errors were encountered: