Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.0 Utility Dataframe Column Changes (effects ARC) #429

Closed
danielsclint opened this issue Jun 15, 2021 · 1 comment
Closed

V1.0 Utility Dataframe Column Changes (effects ARC) #429

danielsclint opened this issue Jun 15, 2021 · 1 comment
Labels
Admin Administrative issue

Comments

@danielsclint
Copy link

When testing the migration of ARC ActivitySim Version 1.0, I encountered a number of dataframe variable name changes as well as YAML syntax differences.

While not terribly complex changes, the V1.0 commits were clearly aware that changes needed to be made to the ARC implementation, because changes were made in the ARC example. In the future, a better way to handle this type of change would be to also submit a PR with the same changes to the ARC GitHub implementation.

These commits also do not adhere to the commit Review Criteria:

  1. Does it appropriately interact with the data pipeline (i.e. it doesn’t create new ways of managing data)?
  2. Does it include sufficient test coverage and test data for existing and proposed features?

Example (Work Location):
image

Example (At-Work Subtour)
image

@jfdman jfdman added the Admin Administrative issue label Dec 9, 2021
@danielsclint
Copy link
Author

This can be closed for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Administrative issue
Projects
None yet
Development

No branches or pull requests

2 participants