Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Mark unread posts with a colored line #526

Closed
K1rakishou opened this issue Jan 25, 2020 · 5 comments
Closed

[IMPROVEMENT] Mark unread posts with a colored line #526

K1rakishou opened this issue Jan 25, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@K1rakishou
Copy link

K1rakishou commented Jan 25, 2020

Remove the line (mark it as read) when a post was either read normally (it was scrolled over) or when a post is opened in a reply chain.

Rationale: this is really useful when you were reading a huge reply chain and then you close it and don't want to read the same posts, so the post marker would be really useful to just ignore those posts and concentrate only on posts you haven't read yet.

Something like this:
345346347347

Read posts (site id (but I think it would be a better idea to somehow the site name - like 4chan.org - instead of id because we really need to get rid of these ids, they are really bad), board code and post id) (I guess it will be really fucking hard, like half of the app will need to be rewritten and then the merge conflicts will literally kill the person who will have to resolve them, so fuck it) should be stored in the DB, no json files allowed! Don't forget to make sure this thing works with local threads.

@K1rakishou K1rakishou added the enhancement New feature or request label Jan 25, 2020
@K1rakishou K1rakishou self-assigned this Jan 25, 2020
@K1rakishou K1rakishou changed the title [IMPROVEMENT] Mark unread posts with a colored line of a side of a post [IMPROVEMENT] Mark unread posts with a colored line Jan 25, 2020
@K1rakishou
Copy link
Author

K1rakishou commented Jan 25, 2020

I guess it would also be a really good idea to refactor PostCell.bindPost() method because right now it's a fucking mess. Or even the whole PostCell because there are lots of things that should be extracted into separate classes.

@K1rakishou
Copy link
Author

We could even use different colors (like for replies to your posts) in future after this task is implemented.

@Astridchan
Copy link

Astridchan commented Jan 25, 2020

Kuroba already uses color lines for the filter highlight feature, it might conflict with this since you'd end up with two different color lines on some posts. Dashchan has this feature except that is uses a slightly different shade of background colors for read and unread replies, might want to check that out.

One suggestion, if this does get implemented then scrolling past a (You) reply should mark it read and clear the notification. Currently you need to scroll to the bottom of the thread to do that.

@K1rakishou
Copy link
Author

K1rakishou commented Jan 25, 2020

@Astridchan Oh damn it, you are right. Then the line could just be ignored for the posts matched by the filters. In other words, the filters would take precedence over this feature, or something like that. I wonder what else I'm missing.

@Adamantcheese
Copy link
Owner

Closing as it seems that most people who use Kuroba-Ex have this disabled anyways. It's neat from a technical standpoint, but adds visual clutter for no real benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants