Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Filter empty subjects, comments, etc.. #922

Closed
ghost opened this issue Jun 9, 2020 · 4 comments
Closed

[Feature Request] Filter empty subjects, comments, etc.. #922

ghost opened this issue Jun 9, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Jun 9, 2020

Filtering by subject, comments, etc. works great, but you still got stuck with all threads leaving the field in question empty. As regex filtering for empty strings doesn't seem to work, I'd suggest adding an "empty" checkbox.

@Adamantcheese
Copy link
Owner

Is this a similar concern as chandevel#744?

@ghost
Copy link
Author

ghost commented Jun 9, 2020

I guess it's pretty much the same issue. Considering it's still up, is this harder to fix than it looks like?

@Adamantcheese Adamantcheese added the enhancement New feature or request label Jun 9, 2020
@Adamantcheese Adamantcheese self-assigned this Jun 9, 2020
@Adamantcheese
Copy link
Owner

Regular expressions that match the empty string (like /^$/) should now work in dev. Note that any expression that would reduce to a pattern input of empty string (like //, "", or any number of spaces) have been prevented, as those would match everything.

@ghost
Copy link
Author

ghost commented Jun 9, 2020

Ah, I'm just on the regular version, thanks for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant