Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use the addon with current version of ember and embroider #1061

Open
Polve opened this issue Jan 3, 2024 · 4 comments
Open

Unable to use the addon with current version of ember and embroider #1061

Polve opened this issue Jan 3, 2024 · 4 comments

Comments

@Polve
Copy link

Polve commented Jan 3, 2024

Using ember-cli 5.5, and creating a new project with the following flags:

ember new --typescript --embroider test-ember-table

Gives this error while building the app:

Some V1 ember addons are resolving as incorrect peer dependencies. This makes it impossible for us to safely convert them to v2 format.
  👇 👇 👇
👉 See https://github.com/embroider-build/embroider/blob/main/docs/peer-dependency-resolution-issues.md for an explanation of the problem and suggestions for fixing it.
  👆 👆 👆

test-ember-table@0.0.0 (dev)-> ember-table@5.0.6 -> ember-classy-page-object@0.8.0-beta.2 -> ember-cli-page-object@2.0.0
    sees peerDep @ember/test-helpers@2.9.4
      at /sandbox/test-ember-table/node_modules/ember-classy-page-object/node_modules/@ember/test-helpers
    but test-ember-table@0.0.0 is using @ember/test-helpers@3.2.1
      at /sandbox/test-ember-table/node_modules/@ember/test-helpers

it's probably some kind of wrong dependency that can easily be fixed but I'm not technical enough to understand if/how

@JamesS-M
Copy link

Have you gotten this to work for you? I'm seeing the same thing while upgrading my app.

@Polve
Copy link
Author

Polve commented Oct 23, 2024

no, I moved on to other things hoping a new release of ember table would come out but for now no luck, it seems

@JamesS-M
Copy link

Alright I'll do the same. Luckily my usage is so simple that a regular html form should do the trick!

@eflanagan0
Copy link

I would also appreciate this addon working with embroider-build.
I believe the error comes from this line in ember-table's package.json:

"ember-classy-page-object": "^0.8.0-beta.2",

You can workaround this by using your package manager's override to ignore ember-table's provided version and use whatever @ember/test-helpers version your application depends on.
In my case, the project uses npm, so I overrode with:

  "overrides": {
    "@ember/test-helpers": "3"
  },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants