-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When custom user agent string field is empty, we should use the User Agent string of the same browser as client uses #917
Comments
@BooBerry I've updated the issue description, please check it out |
I agree, but in the case of IE, Edge and Safari it should also use the OS they're available on (Windows for IE/Edge and Mac for Safari in this case). I'm thinking any other OS would also break stuff when using those browsers. |
We can simply strip everything "extra" from the user agent |
Here's another example where using the Linux user agent causes issues on a Windows machine: http://forum.adguard.com/showthread.php?9493-Win-7-64-bit-identifying-as-Linux The user agent should also match the OS Adguard is running on to prevent issues like this.
Yes, but match OS, browser and browser version to the native browser/OS. The last is important because using an older browser version in the user agent might also break sites, especially email. Just strip everything else. :) |
Yes, I agree, OS and version is also important. |
If the only thing that changes here is the empty User Agent behaviour, then all is well. Please don't prevent Host OS from acting as an alternative OS. I like disguising my Windows 7 OS as Linux via Stealth Mode/User Agent String. I mean seriously, that's the whole point of Stealth isn't it? Preventing this is not a solution, it is a restriction. The drop-down list containing User Agents seems to me to be an optimal solution. It might also benefit those who use User Agent addons in browsers to go with one addon less. |
Yep, the only change is when "user agent" field is empty. You always can set any user agent manually. |
Fixed |
Edit by ameshkov:
We should change the default behavior of "Hide User Agent" feature. When custom user agent string field is empty, we should use the User Agent string of the same browser as client uses.
If user uses IE - use IE user agent, if FF - use FF, etc.
Original text:
http://forum.adguard.com/showthread.php?9324-Trouble-in-Gmail-AG-v-6-0-189-984
Steps to reproduce:
If you change the user agent to a custom one (I used an IE11 user agent in this case) the issue resolves itself.
The text was updated successfully, but these errors were encountered: