Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When custom user agent string field is empty, we should use the User Agent string of the same browser as client uses #917

Closed
BooBerry opened this issue Feb 26, 2016 · 8 comments
Assignees
Milestone

Comments

@BooBerry
Copy link

Edit by ameshkov:
We should change the default behavior of "Hide User Agent" feature. When custom user agent string field is empty, we should use the User Agent string of the same browser as client uses.

If user uses IE - use IE user agent, if FF - use FF, etc.

Original text:
http://forum.adguard.com/showthread.php?9324-Trouble-in-Gmail-AG-v-6-0-189-984

Steps to reproduce:

  1. Enable Enhanced Protected Mode (I also enabled the 64-bit processes for Enhanced Protected Mode option) under IE's settings.
  2. Enable Stealth Mode and enable the Hide your User Agent feature (without setting a custom user agent).
  3. Open IE and go to Gmail with a signed in account (and make sure you have email in the inbox).
  4. Open an email, press the reply button below and try to type into the box. It doesn't work.

If you change the user agent to a custom one (I used an IE11 user agent in this case) the issue resolves itself.

@ameshkov ameshkov added this to the 6.1 milestone Feb 27, 2016
@ameshkov ameshkov changed the title [Stealth Mode] Can't reply to Gmail email in IE11 (with Enhanced Protection Mode enabled) when "Hide your User Agent" is enabled When custom user agent string field is empty, we should use the User Agent string of the same browser as client uses Feb 27, 2016
@ameshkov
Copy link
Member

@BooBerry I've updated the issue description, please check it out

@BooBerry
Copy link
Author

I agree, but in the case of IE, Edge and Safari it should also use the OS they're available on (Windows for IE/Edge and Mac for Safari in this case). I'm thinking any other OS would also break stuff when using those browsers.

@ameshkov
Copy link
Member

We can simply strip everything "extra" from the user agent

@BooBerry
Copy link
Author

BooBerry commented Mar 5, 2016

Here's another example where using the Linux user agent causes issues on a Windows machine: http://forum.adguard.com/showthread.php?9493-Win-7-64-bit-identifying-as-Linux

The user agent should also match the OS Adguard is running on to prevent issues like this.

We can simply strip everything "extra" from the user agent

Yes, but match OS, browser and browser version to the native browser/OS. The last is important because using an older browser version in the user agent might also break sites, especially email. Just strip everything else. :)

@ameshkov
Copy link
Member

ameshkov commented Mar 6, 2016

Yes, I agree, OS and version is also important.

@marzametal
Copy link

If the only thing that changes here is the empty User Agent behaviour, then all is well. Please don't prevent Host OS from acting as an alternative OS.

I like disguising my Windows 7 OS as Linux via Stealth Mode/User Agent String. I mean seriously, that's the whole point of Stealth isn't it? Preventing this is not a solution, it is a restriction. The drop-down list containing User Agents seems to me to be an optimal solution. It might also benefit those who use User Agent addons in browsers to go with one addon less.

@ameshkov
Copy link
Member

ameshkov commented Jun 3, 2016

Yep, the only change is when "user agent" field is empty. You always can set any user agent manually.

@suhan3z
Copy link
Contributor

suhan3z commented Jun 7, 2016

Fixed

@suhan3z suhan3z closed this as completed Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants