Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard adblock agent properly #1667

Closed
ameshkov opened this issue Sep 6, 2022 · 2 comments
Closed

Discard adblock agent properly #1667

ameshkov opened this issue Sep 6, 2022 · 2 comments

Comments

@ameshkov
Copy link
Member

ameshkov commented Sep 6, 2022

Currently, we only discard [Adblock, we should discard more:
[AdBlock], [Adblock Plus], [uBlock] / [uBlock Origin], [AdGuard]

See there for the details:
https://github.com/github/linguist/blob/bf853f1c663903e3ee35935189760191f1c45e1c/lib/linguist/heuristics.yml#L681-L700

@ngorskikh
Copy link
Member

ngorskikh commented Sep 7, 2022

@ameshkov Hmm, I need more context as to what exactly do we need to solve. If I understand correctly, we are talking about handling the first line of a filter list in the filter list processor? Currently, we just pass that to the engine. It won't parse anyway :)

@ameshkov
Copy link
Member Author

ameshkov commented Sep 7, 2022

@ngorskikh search for [Adblock in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants