Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unneeded functions from react-shim.js #181

Open
1 task done
ashryanbeats opened this issue Feb 28, 2019 · 0 comments
Open
1 task done

Removed unneeded functions from react-shim.js #181

ashryanbeats opened this issue Feb 28, 2019 · 0 comments

Comments

@ashryanbeats
Copy link
Member

Submit an issue

Topic

This is an issue regarding:

https://github.com/AdobeXD/plugin-docs/blob/master/tutorials/quick-start-react/index.md

Versions

  • Supported XD version(s): 16+

Description of the issue

Our React Quick Start contains code for a react-shim.js file. Some or all of the functions included there will (or have) become unnecessary as the plugin API evolves.

As of XD 16, we no longer need to shim setTimeout and clearTimeout.

Proposed solution

Let's leave it as-is now, so developers have this option for backwards compatibility.

In a few months, when we no longer need to support older versions of XD with the missing APIs, let's remove unneeded functions, or if possible at some point (much longer term), the entire shim itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant