Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build pipeline ReleaseType=Weekly #2436

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Add build pipeline ReleaseType=Weekly #2436

merged 1 commit into from
Feb 3, 2021

Conversation

andrew-m-leonard
Copy link
Contributor

Add the "Weekly" ReleaseType choice to the build pipeline job, which does the equivalent of a Nightly but with the Weekly test jobs, and then publishes to github.

Signed-off-by: Andrew Leonard anleonar@redhat.com

@andrew-m-leonard
Copy link
Contributor Author

run tests

@andrew-m-leonard andrew-m-leonard self-assigned this Feb 2, 2021
@andrew-m-leonard andrew-m-leonard mentioned this pull request Feb 2, 2021
Closed
@M-Davies M-Davies added enhancement Issues that enhance the code or documentation of the repo in any way jenkins Issues that enhance or fix our jenkins server labels Feb 2, 2021
@andrew-m-leonard
Copy link
Contributor Author

run tests

lumpfish
lumpfish approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@lumpfish lumpfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

sxa
sxa reviewed Feb 2, 2021
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this what we will be using for the OpenJ9 milestone builds? If so that should be called out in the RELEASING.md doc

@adoptopenjdk-github-bot
Copy link
Contributor

🟠 PR TESTER RESULT 🟠

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

1 similar comment
@adoptopenjdk-github-bot
Copy link
Contributor

🟠 PR TESTER RESULT 🟠

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

@andrew-m-leonard
Copy link
Contributor Author

Is this what we will be using for the OpenJ9 milestone builds? If so that should be called out in the RELEASING.md doc

Updated RELEASING.md

@andrew-m-leonard
Copy link
Contributor Author

run tests

sxa
sxa reviewed Feb 2, 2021
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another comment on the naming convention

pipelines/build/common/build_base_file.groovy Outdated Show resolved Hide resolved
@adoptopenjdk-github-bot
Copy link
Contributor

🟢 PR TESTER RESULT 🟢

✅ All pipelines passed! ✅

@andrew-m-leonard
Add build pipeline ReleaseType=Weekly
6a94e84 
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard
Copy link
Contributor Author

run tests

@adoptopenjdk-github-bot
Copy link
Contributor

🟢 PR TESTER RESULT 🟢

✅ All pipelines passed! ✅

sxa
sxa approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the naming fix :-)

@andrew-m-leonard andrew-m-leonard merged commit e8fe420 into adoptium:master Feb 3, 2021
@karianna karianna added this to the February 2021 milestone Feb 3, 2021
@adamfarley adamfarley mentioned this pull request Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumpfish lumpfish lumpfish approved these changes

@M-Davies M-Davies M-Davies approved these changes

@sxa sxa sxa approved these changes

Assignees

@andrew-m-leonard andrew-m-leonard

Labels
enhancement Issues that enhance the code or documentation of the repo in any way jenkins Issues that enhance or fix our jenkins server
Projects
None yet
Milestone
February 2021
Development

Successfully merging this pull request may close these issues.
6 participants
@andrew-m-leonard @adoptopenjdk-github-bot @sxa @M-Davies @lumpfish @karianna