Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change scanning to use the camera's location and not the players in-world location #77

Open
ASchneider-GitHub opened this issue Oct 15, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@ASchneider-GitHub
Copy link

Describe the bug
When Monster Spawner and Mossy Cobblestone are enabled as shown below for the purpose of dungeon-hunting, the renderer doesn't appear to work consistently. I'm unsure of it it's because I'm in free-cam mode, but turning the xray function on and off while outside free-cam mode doesn't seem to fix it. My settings are below:
guiSettings

but when the renderer is enabled, it appears to only render select blocks:
2023-10-14_18 39 26

Despite the distance setting being 15, and the mossy cobblestone and spawner being enabled, you can see in the screenshot above that it's not being detected. The other instances of yellow renders are the correctly detected blocks.

Unsure of whether this is a fault in the mod, or my understanding of how the Distance setting is supposed to work.

To Reproduce
Steps to reproduce the behavior:
Unknown how to reproduce it, because I'm not sure what's causing it. Settings for the mod are in the screenshot above though.

Expected behavior
All mossy cobblestone and spawner blocks within the 15 chunk radius should be detected by the mod. The missed blocks in the screenshot are offset from the player by x=60,y=144,z=125

Minecraft Enviorment

  • Minecraft Version: 1.20.1
  • XRay Mod Version: advanced-xray-fabric-1.20.1-1.6.0-build.17.jar
  • Mod Pack & Version if applicable: N/A
  • Forge Version if applicable N/A
  • Fabric Version: fabric-api-0.85.0+1.20.1.jar

Additional context
Edit: As I was writing this, I realized the mod had missed another dungeon with mossy cobblestone and a spawner in it directly above the instance in the first screenshot. You can actually see the originally-missed dungeon in the bottom center background.
2023-10-14_18 55 25

@MichaelHillcox
Copy link
Collaborator

It uses the real world position of the player, not the camera

@ASchneider-GitHub
Copy link
Author

The instances of missed blocks above are within the 15 chunk radius. Mentioned is that the offset of the missed blocks from the player's location is x=60,y=144,z=125, which is roughly x=4 chunks, z=8 chunks. Is the Distance setting a radius, or a diameter of the whole search area?

@MichaelHillcox MichaelHillcox self-assigned this Oct 17, 2023
@MichaelHillcox MichaelHillcox added the bug Something isn't working label Aug 12, 2024
@MichaelHillcox MichaelHillcox changed the title Xray seems to "miss" enabled blocks when in user is in free-cam mode Change scanning to use the camera's location and not the players in-world location Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants