-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute short names of items #488
Comments
As discussed: I believe this is a good idea. There is just one thing which is not clear to me: do you intend to compute a short name for all names, or only for a small selection of the most common ones (such as |
I intend this for all names. I also intend for the name matcher to optionally work on short names (and raise an error if there could be ambiguity). |
We can also easily add an option to print full names, or add a map from short to full names in the llbc output. |
Ok, understood. A small remark for the name matcher: I think it would be good if the patterns are stable, which would not be the case if we allow matching by using short names (as adding a dependency to a crate might introduce ambiguities, making some previously succeeding patterns suddenly fail). |
Agreed, hence why "optional". I also think short names are a lot more convenient when prototyping so it's a good option to have. |
Items in the pretty output have fully-qualitied names that are hard to read. We could compute for each item a shorter name that is guaranteed to be unique across the whole llbc output, and use that shorter name when displaying to the user.
The text was updated successfully, but these errors were encountered: