New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put common code into a separate file for workflow_docker.py and workflow_scif.py #551

Open

Chris-Schnaufer opened this issue Sep 9, 2021 · 0 comments

Assignees

Labels

DPP UI task

Member

Chris-Schnaufer commented Sep 9, 2021

Task to do
See title

Reason
Pylint is finding much similar code (a known problem) and fails the GitHub action. Currently have work-around to get past the error

Result
Pylint is successful without having special exceptions for workflow_docker.py and workflow_scif.py

Steps to take

Move common code to new file (use lambda functions where it makes sense)
Update the Action YAML file to remove special pylint exceptions: https://github.com/AgPipeline/Atlana/blob/fe9209ff257616e3f0b1e38050891f17ef408f21/.github/workflows/testing_checks.yaml#L47 and https://github.com/AgPipeline/Atlana/blob/fe9209ff257616e3f0b1e38050891f17ef408f21/.github/workflows/testing_checks.yaml#L82-L83

Chris-Schnaufer added the task label

Chris-Schnaufer self-assigned this

Chris-Schnaufer added the DPP UI label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment