fix: add "TODO unimplemented"s #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
commented
Aug 21, 2020
| @@ -118,6 +118,7 @@ export function buildRootObject() { | |||
| return mintyIssuerRecord; | |||
| }, | |||
| mintGains: (gains, zcfSeat = undefined) => { | |||
| // TODO unimplemented | |||
There was a problem hiding this comment.
The grepping did find this case, which is the one we discussed this morning.
michaelfig
approved these changes
Aug 30, 2020
erights
force-pushed
the
add-unimplementeds
branch
from
3e1d41d
to
df0f027
Compare
erights
force-pushed
the
add-unimplementeds
branch
from
df0f027
to
ffe1738
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just grepped for "implemented" to find error messages, etc, that complain that something is not yet implemented, or words to that effect. Added a
// TODO unimplementedto make these easier to find, as a first step a towards a more principled treatment of these.
Please look at each individual case and advise if it needs a different approach immediately.