Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add displayInfo as a parameter to makeZcfMint. #2189

Merged
merged 2 commits into from
Jan 13, 2021
Merged

feat: add displayInfo as a parameter to makeZcfMint. #2189

merged 2 commits into from
Jan 13, 2021

Conversation

Chris-Hibbert
Copy link
Contributor

with tests

@Chris-Hibbert Chris-Hibbert added this to the MetaMask Agoric-Ethereum Bridge Demo milestone Jan 13, 2021
@Chris-Hibbert Chris-Hibbert self-assigned this Jan 13, 2021
katelynsills
katelynsills approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@katelynsills katelynsills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Chris-Hibbert Chris-Hibbert merged commit f5cb3b9 into master Jan 13, 2021
@Chris-Hibbert Chris-Hibbert deleted the displayInfoZcfMint branch January 13, 2021 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katelynsills katelynsills katelynsills approved these changes

@michaelfig michaelfig Awaiting requested review from michaelfig

Assignees

@Chris-Hibbert Chris-Hibbert

Labels
wallet Zoe package: Zoe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chris-Hibbert @katelynsills