Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: agoric client docker-compose config #2701

Merged
merged 10 commits into from
Mar 24, 2021
Merged

feat: agoric client docker-compose config #2701

merged 10 commits into from
Mar 24, 2021

Conversation

dckc
Copy link
Member

@dckc dckc commented Mar 23, 2021

sorta starting to work

goal:
fixes #2697 fixes #2705

@dckc dckc requested a review from michaelfig March 23, 2021 01:07
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LRNTM! Looks really-noice to me.

@dckc
Copy link
Member Author

dckc commented Mar 23, 2021

does it actually work for you?

@dckc
Copy link
Member Author

dckc commented Mar 23, 2021

also: is this where these files should go?

I had to git add -f .env to override .gitignore. That seem hazardous.

@michaelfig
Copy link
Member

does it actually work for you?

I just now tested, but it needed another push. Now it seems to work.

@michaelfig
Copy link
Member

also: is this where these files should go?

It may be better to put them somewhere in the top of the SDK (agoric-sdk/docker or something), for discoverability?

I had to git add -f .env to override .gitignore. That seem hazardous.

That's acceptable from time to time. I'm okay with it.

@dckc
Copy link
Member Author

dckc commented Mar 23, 2021

Now it seems to work.

And what does that look like?

For me, it says start: adding HTTP/WS listener on 127.0.0.1:8000 but I get connection refused there. Is there some docker networking step I missed?

And it still spins with Error running ag-cosmos-helper query swingset egress agoric12ssfrtkkyppman765qg3ckyjvmahpw6ecx6yvt even well after I did !faucet client ....

@dckc
Copy link
Member Author

dckc commented Mar 23, 2021

.env might not be necessary... "${PASS:-secret}" is reported to work: docker/docs#6914 (comment)

@michaelfig
Copy link
Member

I added a quick README.md.

The Dockerfile commit above (additional /usr/local/bin/agoric symlink) will mean in the future you don't need to prepend npx before the agoric open ....

@dckc dckc force-pushed the 2697-docker-client branch 3 times, most recently from a6227e9 to 4e7952b Compare March 23, 2021 21:08
@dckc dckc requested a review from rowgraus March 23, 2021 21:10
@dckc
Copy link
Member Author

dckc commented Mar 23, 2021

@rowgraus we put some instructions in https://github.com/Agoric/agoric-sdk/tree/2697-docker-client/docker ; take a look, please?

@dckc dckc force-pushed the 2697-docker-client branch 5 times, most recently from 855095b to 414a4d3 Compare March 23, 2021 21:31
@dckc dckc marked this pull request as ready for review March 23, 2021 21:59
@dckc dckc requested a review from michaelfig March 23, 2021 21:59
@dckc dckc changed the title feat: agoric client docker-compose config (WIP) feat: agoric client docker-compose config Mar 23, 2021
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. And it actually works, too!

@dckc dckc enabled auto-merge (squash) March 24, 2021 01:50
@dckc dckc merged commit c9ae4fd into master Mar 24, 2021
@dckc dckc deleted the 2697-docker-client branch March 24, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants