Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augment refcount audit in kerneldump to include kernel objects #3445

Closed
FUDCo opened this issue Jul 2, 2021 · 0 comments
Closed

Augment refcount audit in kerneldump to include kernel objects #3445

FUDCo opened this issue Jul 2, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request SwingSet package: SwingSet swingset-runner package: swingset-runner tooling repo-wide infrastructure

Comments

@FUDCo
Copy link
Contributor

FUDCo commented Jul 2, 2021

What is the Problem Being Solved?

Back when we were working on kernel promise retirement we added a feature to the kerneldump utility to run a comprehensive audit of the kernel promise reference counts to verify that we doing them correctly and help diagnose problems when we weren't. Since then, we've added sophisticated inter-vat garbage collection logic which adds reference counts to kernel objects in addition to refcounting promises. The kerneldump refcount audit mechanism should be extended to encompass those, for all the same reasons that feature was added in the first place.

Description of the Design

Promise refcounts are single counts whereas object refcounts are pairs (reachable + recognizable), but otherwise the logic is the same. The current utility looks at all the places that references can live and adds them up. Just so.

@FUDCo FUDCo added enhancement New feature or request SwingSet package: SwingSet swingset-runner package: swingset-runner tooling repo-wide infrastructure labels Jul 2, 2021
@FUDCo FUDCo self-assigned this Jul 2, 2021
@FUDCo FUDCo mentioned this issue Jul 9, 2021
@FUDCo FUDCo closed this as completed in d7c9792 Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request SwingSet package: SwingSet swingset-runner package: swingset-runner tooling repo-wide infrastructure
Projects
None yet
Development

No branches or pull requests

1 participant