Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add limits for amounts between vault and vault manager #4599

Closed
turadg opened this issue Feb 18, 2022 · 4 comments
Closed

Add limits for amounts between vault and vault manager #4599

turadg opened this issue Feb 18, 2022 · 4 comments
Labels
Core Economy OBSOLETE in favor of INTER-protocol enhancement New feature or request needs-design restival to be done before RUN Protocol Purple Team festival Vaults VaultFactor (née Treasury)
Milestone
Mainnet 1 RC0

Comments

@turadg
Copy link
Member

turadg commented Feb 18, 2022 •
edited
Loading

What is the Problem Being Solved?

Right now the amounts being passed between them have no limits. We should have them as a security/reliability assurance.

Description of the Design

Some ideas in #4527 (comment)

  • it should never be more than the max allowed for a vault
  • should never be larger than this manager's total debt (so a bug in one manager can screw up the debt limit on the overall service)

Security Considerations

Improvement.

Test Plan

--
@turadg turadg added Core Economy OBSOLETE in favor of INTER-protocol enhancement New feature or request labels Feb 18, 2022
@turadg turadg mentioned this issue Feb 18, 2022
Merged
7 tasks
@Tartuffo Tartuffo added the restival to be done before RUN Protocol Purple Team festival label Feb 23, 2022
@Tartuffo
Copy link
Contributor

Consider at Restival.

@Chris-Hibbert Chris-Hibbert added the Vaults VaultFactor (née Treasury) label Mar 10, 2022
@Tartuffo
Copy link
Contributor

We the decided the Vault should call the Vault Manager for minting. (RUNStake should do the same thing.)

@dtribble dtribble mentioned this issue Mar 20, 2022
Merged
6 tasks
@dtribble
Copy link
Member

The vault calling the manager to simultaneously mint and record that in the stats works well. And doing the same thing with burn ensures that the number is only debited when tokens are actually burned.

@Tartuffo Tartuffo added this to the Mainnet 1 milestone Mar 23, 2022
@dtribble
Copy link
Member

dtribble commented Apr 4, 2022

This was addressed via moving minting into vaultManager

@dtribble dtribble closed this as completed Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Core Economy OBSOLETE in favor of INTER-protocol enhancement New feature or request needs-design restival to be done before RUN Protocol Purple Team festival Vaults VaultFactor (née Treasury)
Projects
None yet
Milestone
Mainnet 1 RC0
Development

No branches or pull requests
5 participants
@turadg @dckc @Tartuffo @dtribble @Chris-Hibbert