Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verify by end-to-end test a contract on-chain can be upgraded #6099

Closed
Tracked by #7491
Chris-Hibbert opened this issue Aug 31, 2022 · 8 comments · Fixed by #7691
Closed
Tracked by #7491

verify by end-to-end test a contract on-chain can be upgraded #6099

Chris-Hibbert opened this issue Aug 31, 2022 · 8 comments · Fixed by #7691
Assignees
@michaelfig
Labels
enhancement New feature or request Inter-protocol Overarching Inter Protocol vaults_triage DO NOT USE
Milestone
Vaults Validation

Comments

@Chris-Hibbert
Copy link
Contributor

Chris-Hibbert commented Aug 31, 2022 •
edited by michaelfig
Loading

What is the Problem Being Solved?

After the bulldozer, the only way to upgrade contracts will be through the AdminFacet's upgradeContract(). We don't have experience yet executing that in a live chain.

Description of the Design

A chain integration test that does the following:

  • bundle and install a buggy contract via a proposal
  • use a smart wallet to demonstrate the bug
  • bundle and upgrade to a contract that preserves the buggy one's state but fixes the bug
  • use a smart wallet to demonstrate that the state is preserved and the bug is fixed

Security Considerations

The relevant security here is the feeling of confidence that we can do something about it if a problem is discovered in a contract on a live chain.

Test Plan

Demonstrate one contract being upgraded on a running chain.
@Chris-Hibbert Chris-Hibbert added enhancement New feature or request Inter-protocol Overarching Inter Protocol pso labels Aug 31, 2022
@Chris-Hibbert Chris-Hibbert added this to the Mainnet 1 RC0 milestone Aug 31, 2022
@Chris-Hibbert Chris-Hibbert self-assigned this Aug 31, 2022
This was referenced Aug 31, 2022
Closed
Merged
Closed
@dckc
Copy link
Member

dckc commented Sep 2, 2022

@kriskowal help me try agoric bundle and agoric publish on ollinet, please?

@kriskowal
Copy link
Member

@kriskowal help me try agoric bundle and agoric publish on ollinet, please?

I’ll implement them right away #6087

@dckc
Copy link
Member

dckc commented Sep 3, 2022

needs #5460 ; currently agd query vstorage children published doesn't include installation.

This was referenced Sep 4, 2022
Closed
Open
@kriskowal
Copy link
Member

I’ve made a first attempt to upgrade PSM and encountered an error in upgradeContract behavior #6207

@Tartuffo
Copy link
Contributor

Moving this out of the critical path for the PSM-First launch. We can side-grade the PSM to a new contract:

  1. Turn off the offer sides of the old PSM contact
  2. Stand up a new PSM contract
  3. Use JS Hammer to:
    a. mint a bunch of IST
    b. buy the USDC from the old contract
    c. put the USDC in a new PSM
    d. burn the bunch of IST
  4. Tear down the old contract

@dckc
Copy link
Member

dckc commented Sep 15, 2022 •
edited
Loading

we also have a couple other options:

@Tartuffo Tartuffo removed this from the Mainnet 1 RC0 milestone Sep 21, 2022
@Tartuffo Tartuffo removed the pso label Sep 21, 2022
@dckc dckc mentioned this issue Nov 9, 2022
Closed
@ivanlei ivanlei added vaults_triage DO NOT USE and removed vaults-release labels Jan 4, 2023
@dckc dckc mentioned this issue Jan 25, 2023
Closed
@turadg
Copy link
Member

turadg commented Apr 20, 2023 •
edited
Loading

@dckc going to take this on because @kriskowal is out. I'm taking on a dependency,

@turadg turadg assigned turadg and unassigned kriskowal Apr 20, 2023
@turadg turadg changed the title Verify upgradability of PSM make PSM upgradable Apr 20, 2023
@turadg turadg assigned dckc and unassigned turadg Apr 20, 2023
@turadg turadg changed the title make PSM upgradable verify by end-to-test that contracts on-chain can be upgraded Apr 20, 2023
@turadg turadg changed the title verify by end-to-test that contracts on-chain can be upgraded verify by end-to-test a contract on-chain can be upgraded Apr 24, 2023
@turadg turadg mentioned this issue Apr 24, 2023
Closed
@dckc dckc mentioned this issue Apr 25, 2023
Closed
@ivanlei ivanlei modified the milestones: Vaults EVP, Vaults Validation Apr 28, 2023
@dckc dckc mentioned this issue May 1, 2023
Closed
@ivanlei ivanlei assigned michaelfig and unassigned dckc May 11, 2023
@michaelfig michaelfig changed the title verify by end-to-test a contract on-chain can be upgraded verify by end-to-end test a contract on-chain can be upgraded May 11, 2023
@michaelfig michaelfig mentioned this issue May 11, 2023
Merged
@dckc dckc mentioned this issue May 12, 2023
Closed
@Tartuffo
Copy link
Contributor

Congrats everyone! This is a major accomplishment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelfig michaelfig

Labels
enhancement New feature or request Inter-protocol Overarching Inter Protocol vaults_triage DO NOT USE
Projects
None yet
Milestone
Vaults Validation
Development

Successfully merging a pull request may close this issue.

test(deployment): end-to-end test of on-chain contract upgrade Agoric/agoric-sdk
7 participants
@turadg @kriskowal @dckc @michaelfig @Tartuffo @ivanlei @Chris-Hibbert